-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43963/#review120650
-----------------------------------------------------------


Ship it!




Verify that add unbuffer works!

- haosdent huang


On Feb. 25, 2016, 2 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43963/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2016, 2 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Timothy Chen.
> 
> 
> Bugs: MESOS-4676
>     https://issues.apache.org/jira/browse/MESOS-4676
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds the `unbuffer` utility in front of each `echo` in the test.  Since 
> Docker appears to handle simultaneous stdout/stderr in a non-robust fashion, 
> this mitigates the amount of overlap the two streams will have in the test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a299c9e0744b5657984e5bb0afbe4874a266ddb6 
> 
> Diff: https://reviews.apache.org/r/43963/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> On Centos7: sudo bin/mesos-tests.sh --gtest_filter="\*ROOT_DOCKER_Logs" 
> --gtest_repeat=1200 --gtest_break_on_failure
> 
> ---
> 
> CI results: 
> sudo make check
> 
>          | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
> Ubuntu 12 |
>  Non-SSL |  :) |    :)    |     *    |    :)    |       :)     |    :)     |  
>    :)    |
> With-SSL |  :) |    :)    |    &*    |     &    |        ^     |    :)     |  
>    :)    |
> 
>  :) = Passed.
> 
> Known flaky tests:
>   * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes
>   & = MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery
>   ^ = LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to