----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43932/#review120649 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/backend.cpp (lines 23 - 24) <https://reviews.apache.org/r/43932/#comment182110> add a blank line here src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 55) <https://reviews.apache.org/r/43932/#comment182111> what about adding user name in the Error message? src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 106) <https://reviews.apache.org/r/43932/#comment182112> just a question, does there are any policy when to use `Failure` and `Error` src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 115) <https://reviews.apache.org/r/43932/#comment182113> return Failure( "Failed to create container rootfs at '" + rootfs + "': " + mkdir.error()); - Guangya Liu On 二月 24, 2016, 4:38 p.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43932/ > ----------------------------------------------------------- > > (Updated 二月 24, 2016, 4:38 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-2971 > https://issues.apache.org/jira/browse/MESOS-2971 > > > Repository: mesos > > > Description > ------- > > Added overlayfs provisioning backend. > > > Diffs > ----- > > src/CMakeLists.txt b13fb23219ebb23bcfd6db062e1c814ca2114aa4 > src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 > src/slave/containerizer/mesos/provisioner/backend.cpp > 01d06ebc67e259272ee57ea5c75bf7077ede65c4 > src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION > src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d > src/tests/containerizer/provisioner_backend_tests.cpp > 25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8 > src/tests/environment.cpp 6cd295f76496770774d090e0485ff87be378f74c > > Diff: https://reviews.apache.org/r/43932/diff/ > > > Testing > ------- > > sudo modprobe overlayfs > sudo make check -j4 > GTEST_FILTER='OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend' > > - OS: ubuntu 14.04 64bit vm > - Kernel: 4.2.0-27-generic > > > Thanks, > > Shuai Lin > >
