----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43971/#review120671 -----------------------------------------------------------
Ship it! Ship It! - Joris Van Remoortere On Feb. 25, 2016, 1:01 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43971/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 1:01 a.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-4768 > https://issues.apache.org/jira/browse/MESOS-4768 > > > Repository: mesos > > > Description > ------- > > The accept/decline of the inverse offers in the test could arrive after the > clock is paused and advanced in the test. This meant that the test would > trigger an allocation and then idle (because the clock is paused). This is > the same problem we fixed in https://issues.apache.org/jira/browse/MESOS-4059 > . > > > Diffs > ----- > > src/tests/master_maintenance_tests.cpp > c9e3828933d16ec65298e4ad4b1a3e0ddf99032d > > Diff: https://reviews.apache.org/r/43971/diff/ > > > Testing > ------- > > make check (OSX) > > bin/mesos-tests.sh --gtest_filter="MasterMaintenanceTest.InverseOffers" > --gtest_repeat=5000 --gtest_break_on_failure > > > Thanks, > > Joseph Wu > >
