-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43961/#review120683
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/isolator_tests.cpp (line 813)
<https://reviews.apache.org/r/43961/#comment182141>

    "finished exec'ing" reads like "finished executing", i.e. the process has 
terminated. But that's not what is meant here! Only after I realized this, the 
sequence of events here became clear to me. Suggestion:
    
        // This observation ensures that the "cat" process 
        // has completed its part of the exec() procedure 
        // and is now executing normally."


- Bernd Mathiske


On Feb. 24, 2016, 9:59 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43961/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 9:59 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Chi Zhang, Artem Harutyunyan, and 
> Jian Qiu.
> 
> 
> Bugs: MESOS-4677
>     https://issues.apache.org/jira/browse/MESOS-4677
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds a set of pipes to mitigate a race between `exec`ing + updating cgroup 
> tasks and the test reading said cgroup tasks.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 653b037c489072f43e53dec01a811a9249dcd660 
> 
> Diff: https://reviews.apache.org/r/43961/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Centos7: sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Pids_and_Tids" 
> --gtest_repeat=5000 --gtest_break_on_failure
> 
> ---
> 
> CI results:
> 
> sudo make check
> 
>          | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
> Ubuntu 12 |
>  Non-SSL |  :) |    @_@   |     *    |    X_X   |       :)     |    :)     |  
>    :)    |
> With-SSL |  :) |    @_@   |     *    |     &    |       :)     |    :)     |  
>    :)    |
> 
>  :) = Passed.
> X_X = Configuration error with docker.
> @_@ = Ran out of disk space in some tests: 
> LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable, 
> LinuxFilesystemIsolatorTest.ROOT_MultipleContainers, 
> MesosContainerizerLaunchTest.ROOT_ChangeRootfs, 
> LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem
> 
>   * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes (Known 
> issue)
>   % = DockerContainerizerTest.ROOT_DOCKER_Logs
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to