-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43883/#review120688
-----------------------------------------------------------




docs/monitoring.md (line 905)
<https://reviews.apache.org/r/43883/#comment182147>

    s/framework_filters/framework_offer_filters
    
    and ditto for the following
    
    There are both offer filter and inverse offer filter in allocator, it is 
better to clarify that this is offer filter.
    
    BTW: Do u have any plan to add inverse offer filter metrics?



src/master/allocator/mesos/hierarchical.hpp (line 402)
<https://reviews.apache.org/r/43883/#comment182148>

    s/filters/offer filters



src/master/allocator/mesos/hierarchical.cpp (line 265)
<https://reviews.apache.org/r/43883/#comment182149>

    move the comments to the below line


- Guangya Liu


On 二月 25, 2016, 11:01 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43883/
> -----------------------------------------------------------
> 
> (Updated 二月 25, 2016, 11:01 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4722
>     https://issues.apache.org/jira/browse/MESOS-4722
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added allocator metrics for number of filters per framework.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43883/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to