> On Feb. 25, 2016, 12:09 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp, lines > > 73-74 > > <https://reviews.apache.org/r/43411/diff/2/?file=1253408#file1253408line73> > > > > We're only testing that `loadSymbol` fails if we don't call `open` > > first, not `close`. Right? Seems like this was copy/pasted from above test.
Yep. I copied it. My bad. :( - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/#review120616 ----------------------------------------------------------- On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43411/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 12:59 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4496 > https://issues.apache.org/jira/browse/MESOS-4496 > > > Repository: mesos > > > Description > ------- > > Windows: Added dynamic library loading tests to build. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt > 3c65d0422dc6e198180d53d1c9e6cb2839137434 > 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp > 27626ae28db090f1a002239ff5c674b82e8fc9a8 > > Diff: https://reviews.apache.org/r/43411/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
