----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43905/#review120821 -----------------------------------------------------------
Bad patch! Reviews applied: [43905, 43904, 43903, 43709, 43708, 43707, 43699, 43698, 43697, 43700, 43689, 43695, 43694, 43693, 43692, 43691, 42579, 43418, 43417, 43416, 43414, 43413, 43415, 43411, 43410, 43409, 43407, 40340, 40195, 40131] Failed command: ./support/apply-review.sh -n -r 40340 Error: 2016-02-26 03:50:16 URL:https://reviews.apache.org/r/40340/diff/raw/ [14026/14026] -> "40340.patch" [1] error: .gitignore-template: does not exist in index error: patch failed: support/mesos-style.py:8 error: support/mesos-style.py: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/11654/console - Mesos ReviewBot On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43905/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 7:17 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > ------- > > `su` does not exist on Windows. Unfortunately, the launcher also depends > on it. In this commit, we remove Windows support for the launcher flag > `user`, which controls whether we use `su` in the launcher. This > allows us to divest ourselves of `su` altogether on Windows. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > d917a99a46841156dc1e359c44010938cc45e943 > src/slave/containerizer/mesos/containerizer.cpp > 129406abdff715e321f683911e404c46676b6daf > src/slave/containerizer/mesos/launch.hpp > 7e29ca2b8bec1c20aef122472cff60f6003603ad > src/slave/containerizer/mesos/launch.cpp > 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 > > Diff: https://reviews.apache.org/r/43905/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
