----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43800/#review120823 -----------------------------------------------------------
This needs a prominent note in `upgrades.md` about the change to the ACL format. Thinking about it, the ACL isn't stored anywhere, so there's no issue with incompatibility of stored state. Similarly, rolling upgrades should be okay -- a mixed cluster would behave in a strange way in the event of master failover, but that's probably to be expected. docs/authorization.md (line 37) <https://reviews.apache.org/r/43800/#comment182328> Not yours, but I feel like we need a better way to organize this information. Maybe a table/matrix, showing the action X is used with subjects Y and objects Z? docs/persistent-volume.md (line 39) <https://reviews.apache.org/r/43800/#comment182329> I'd say "appropriate" rather than "desired". docs/reservation.md (line 54) <https://reviews.apache.org/r/43800/#comment182330> I'd say "appropriate" rather than "desired". - Neil Conway On Feb. 25, 2016, 5:45 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43800/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 5:45 p.m.) > > > Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway. > > > Bugs: MESOS-4591 > https://issues.apache.org/jira/browse/MESOS-4591 > > > Repository: mesos > > > Description > ------- > > Updated docs for reservation, volumes, and authZ. > > This updates the authorization documentation to include the new `roles` > object for the `CreateVolume` and `ReserveResources` ACLs. The docs for > persistent volumes and dynamic reservations are also updated to reflect the > new authorization behavior. > > > Diffs > ----- > > docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab > docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de > docs/reservation.md b98ebe6df0739b48c5fa58e087fd64b1c6c5d456 > > Diff: https://reviews.apache.org/r/43800/diff/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
