-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43778/#review120832
-----------------------------------------------------------




src/tests/persistent_volume_endpoints_tests.cpp (line 839)
<https://reviews.apache.org/r/43778/#comment182344>

    `const`



src/tests/persistent_volume_endpoints_tests.cpp (line 874)
<https://reviews.apache.org/r/43778/#comment182348>

    Unused variable.



src/tests/persistent_volume_endpoints_tests.cpp (line 1066)
<https://reviews.apache.org/r/43778/#comment182349>

    Unused variable.



src/tests/persistent_volume_endpoints_tests.cpp (line 1082)
<https://reviews.apache.org/r/43778/#comment182350>

    `response` seems a bit more concise.


- Neil Conway


On Feb. 24, 2016, 6:42 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43778/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 6:42 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-4591
>     https://issues.apache.org/jira/browse/MESOS-4591
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added '/create-volumes' tests with multiple roles.
> 
> Operators may create volumes for multiple roles in the same operation; this 
> patch adds tests to confirm correct behavior of authorization in this case. 
> The tests `ReservationEndpointsTest.GoodReserveACLMultipleRoles` and 
> `ReservationEndpointsTest.BadReserveACLMultipleRoles` were added.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 6069ca1e9ed278459c5182e438417e95955b1924 
> 
> Diff: https://reviews.apache.org/r/43778/diff/
> 
> 
> Testing
> -------
> 
> Ran `configure && make check` and `configure --enable-libevent --enable-ssl 
> && make check` on OSX; all tests passed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to