----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44058/#review120849 -----------------------------------------------------------
Bad patch! Reviews applied: [44058] Failed command: ./support/apply-review.sh -n -r 44058 Error: 2016-02-26 09:34:14 URL:https://reviews.apache.org/r/44058/diff/raw/ [4122/4122] -> "44058.patch" [1] Total errors found: 0 Checking 3 files Error: Commit message summary (the first line) must not exceed 72 characters. Full log: https://builds.apache.org/job/mesos-reviewbot/11661/console - Mesos ReviewBot On Feb. 26, 2016, 7:19 a.m., fan du wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44058/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 7:19 a.m.) > > > Review request for mesos, Greg Mann, haosdent huang, and Jie Yu. > > > Bugs: MESOS-4492 > https://issues.apache.org/jira/browse/MESOS-4492 > > > Repository: mesos > > > Description > ------- > > Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation > > > Diffs > ----- > > src/master/master.cpp 8d6d3c6468c6b85fe09c33cf9747cc3d1f515ab9 > src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 > src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 > > Diff: https://reviews.apache.org/r/44058/diff/ > > > Testing > ------- > > 1. make check on Centos-7 (3.10.0-123.el7.x86_640 > 2. Verify its functionality with 'reserve' http endpoint as an test case > > # curl http://ipdc02-kvm-guest2:5050/metrics/snapshot | python -mjson.tool | > grep reserve > "master/messages_reserve_resource": 0.0, > "master/messages_unreserve_resource": 0.0, > > > # curl -i -d slaveId=6250553a-2f39-4a92-9073-4618d130f433-S1 -d resources='[ > { "name": "cpus", "type": "SCALAR","scalar": { "value": 1 > },"reservation":{"principal": "XiaoHaHa"}} ]' -X POST > ipdc02-kvm-guest2:5050/master/reserve > HTTP/1.1 200 OK > Date: Fri, 26 Feb 2016 19:59:01 GMT > Content-Length: 0 > > # curl http://ipdc02-kvm-guest2:5050/metrics/snapshot | python -mjson.tool | > grep reserve > "master/messages_reserve_resource": 1.0, > "master/messages_unreserve_resource": 0.0, > > > Thanks, > > fan du > >
