> On Feb. 26, 2016, 5:42 a.m., Neil Conway wrote: > > src/tests/reservation_endpoints_tests.cpp, line 1273 > > <https://reviews.apache.org/r/43779/diff/3/?file=1268359#file1268359line1273> > > > > The analogous test for volumes names these variables differently > > (`volume1`, `volume2`, and `volumes`). We should be consistent
I renamed `volumes` to `volumesMultipleRoles`, but I kept the volumes/dynamicallyReserved distinction, which seems useful to me in terms of readability. i.e., these are dynamically reserved resources, and the others are persistent volumes, so the different variable names are a bit more descriptive. I don't have strong feelings about it though, so feel free to reopen if you disagree :-) - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/#review120829 ----------------------------------------------------------- On Feb. 26, 2016, 4:58 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43779/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 4:58 p.m.) > > > Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway. > > > Bugs: MESOS-4591 > https://issues.apache.org/jira/browse/MESOS-4591 > > > Repository: mesos > > > Description > ------- > > Added '/reserve' tests with multiple roles. > > Operators may reserve resources for multiple roles in the same operation; > this patch adds tests to confirm correct behavior of authorization in this > case. The tests `ReservationEndpointsTest.GoodReserveACLMultipleRoles` and > `ReservationEndpointsTest.BadReserveACLMultipleRoles` were added. > > > Diffs > ----- > > src/tests/reservation_endpoints_tests.cpp > 32b2af4115211b58a5127a14dd19152c2eca120c > > Diff: https://reviews.apache.org/r/43779/diff/ > > > Testing > ------- > > Ran `configure && make check` and `configure --enable-libevent --enable-ssl > && make check` on OSX; all tests passed. > > > Thanks, > > Greg Mann > >
