-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44005/#review120901
-----------------------------------------------------------



As I mentioned in the other review, my suspicion is that not might not be the 
right place for the `Find*.cmake` configuration logic to be at. To recap: my 
rationale is basically that Stout introduces the SVN and APR dependencies and 
therefore it should be handled by a `StoutConfigure.cmake` script.

This was the justification behind the following 3 commits, which I think should 
address the problems you are having here? :) let me know.

https://reviews.apache.org/r/43697/
https://reviews.apache.org/r/43698/
https://reviews.apache.org/r/43699/

- Alex Clemmer


On Feb. 25, 2016, 3:28 p.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44005/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2016, 3:28 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-4773
>     https://issues.apache.org/jira/browse/MESOS-4773
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: StoutTestsConfigure-removed FindApr & FindSvn, moved to master.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
> a27cb98fa45cbd135ebfeca65e215fb3ff054739 
> 
> Diff: https://reviews.apache.org/r/44005/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu along with:
> https://reviews.apache.org/r/44007/
> https://reviews.apache.org/r/44008/
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Reply via email to