----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44070/#review120908 -----------------------------------------------------------
3rdparty/libprocess/include/process/metrics/metrics.hpp (line 74) <https://reviews.apache.org/r/44070/#comment182451> We don't really use `std::unique_ptr` yet. A grep for it only shows messages to do it at some point. In the meantime, let's be consistent and keep using `Owned`. 3rdparty/libprocess/src/metrics/metrics.cpp (lines 38 - 44) <https://reviews.apache.org/r/44070/#comment182436> I think it would be nicer to have this in the `limiter.hpp` file. 3rdparty/libprocess/src/metrics/metrics.cpp (lines 48 - 50) <https://reviews.apache.org/r/44070/#comment182450> We have `Option<std::string> os::getenv(const std::string&)` which I think is a better fit for what you're trying to achieve. 3rdparty/libprocess/src/metrics/metrics.cpp (line 55) <https://reviews.apache.org/r/44070/#comment182452> Not yours but, could you add at least a TODO saying this should be configurable? Two permissions every second sounds rather arbitrary. - Alexander Rojas On Feb. 26, 2016, 4:08 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44070/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 4:08 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-4776 > https://issues.apache.org/jira/browse/MESOS-4776 > > > Repository: mesos > > > Description > ------- > > Allowed disabling metrics endpoint rate limiting via the environment. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/metrics.hpp > 09b716be56eac38f75d79d917799c001aa0b205c > 3rdparty/libprocess/src/metrics/metrics.cpp > a9840083722dd6b7b6aab692ed449407ab125ac7 > > Diff: https://reviews.apache.org/r/44070/diff/ > > > Testing > ------- > > make check (OS X, not optimized) > > > Thanks, > > Benjamin Bannier > >
