----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44073/#review120938 -----------------------------------------------------------
src/tests/main.cpp (line 75) <https://reviews.apache.org/r/44073/#comment182469> I think this is using the posix `setenv(const char*, const char*, int)`, though the boolean as last parameter makes me doubt. I'd recommend using our own `os::setenv(std::string, std::string, bool)` - Alexander Rojas On Feb. 26, 2016, 5:12 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44073/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 5:12 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-4783 > https://issues.apache.org/jira/browse/MESOS-4783 > > > Repository: mesos > > > Description > ------- > > Disabled metrics endpoint rate limiting in mesos tests. > > > Diffs > ----- > > src/tests/main.cpp 942488e57419ace8b7a821f53024aced0f43c7d9 > > Diff: https://reviews.apache.org/r/44073/diff/ > > > Testing > ------- > > make distcheck (ubuntu 12 & 14), make check (OS X) > > > Thanks, > > Benjamin Bannier > >
