----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/#review120997 -----------------------------------------------------------
Ship it! Ship It! - Michael Park On Feb. 26, 2016, 10:21 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42733/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 10:21 p.m.) > > > Review request for mesos, Michael Park, Neil Conway, and Vinod Kone. > > > Bugs: MESOS-3940 > https://issues.apache.org/jira/browse/MESOS-3940 > > > Repository: mesos > > > Description > ------- > > Added checks for presence of `ReservationInfo.principal`. > > The `ReservationInfo.principal` field was recently made `optional`. There > remain a couple places in the code that assume this field is always set. This > patch uses `has_principal()` before this field is accessed to ensure safety. > > > Diffs > ----- > > src/common/resources.cpp 5d731870542166cec11f9956ccdf16207b2d22cc > src/master/master.cpp 8d6d3c6468c6b85fe09c33cf9747cc3d1f515ab9 > src/v1/resources.cpp 207eb61d6a6d03d314539d42751cac65fcffa9af > > Diff: https://reviews.apache.org/r/42733/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
