-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43882/#review121029
-----------------------------------------------------------




src/master/allocator/mesos/hierarchical.hpp (line 360)
<https://reviews.apache.org/r/43882/#comment182620>

    There is a second parameter in the `Timer` object which allows you to 
specify a window, once this window is enabled we can get statistics of the run 
beyond how long the last allocation took place (note that allocation varies a 
lot since sometimes it goes through a few elements and other times goes 
throught the whole cluster).



src/master/allocator/mesos/hierarchical.cpp (line 1220)
<https://reviews.apache.org/r/43882/#comment182612>

    Add a `CHECK_NOT_NULL`



src/master/allocator/mesos/hierarchical.cpp (line 1236)
<https://reviews.apache.org/r/43882/#comment182615>

    While I prefer this kind of constructors. I think I rather go for 
consistency and Mesos code is rather consistent on using parenthesis.
    
    If you look at this file, this will be the only instance of this style (not 
including initializer lists that is).


- Alexander Rojas


On Feb. 26, 2016, 6:01 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43882/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4721
>     https://issues.apache.org/jira/browse/MESOS-4721
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added allocation metrics for allocation time.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43882/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to