> On Feb. 26, 2016, 8:29 p.m., Vinod Kone wrote: > > src/scheduler/scheduler.cpp, line 394 > > <https://reviews.apache.org/r/43662/diff/3/?file=1271056#file1271056line394> > > > > what if we are in CONNECTING state?
Good catch. I had missed that. Added a explicit check for CONNECTING too. > On Feb. 26, 2016, 8:29 p.m., Vinod Kone wrote: > > src/scheduler/scheduler.cpp, line 585 > > <https://reviews.apache.org/r/43662/diff/3/?file=1271056#file1271056line585> > > > > what about other states? Added an explicit check for SUBSCRIBED. > On Feb. 26, 2016, 8:29 p.m., Vinod Kone wrote: > > src/scheduler/scheduler.cpp, line 549 > > <https://reviews.apache.org/r/43662/diff/3/?file=1271056#file1271056line549> > > > > Do we need 'subscribed' as a member variable now? Can we not detect > > this via state and/or connectionID? As per our discussion, let me do this change in a separate patch both for scheduler/executor. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43662/#review120947 ----------------------------------------------------------- On Feb. 25, 2016, 4:27 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43662/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 4:27 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3570 > https://issues.apache.org/jira/browse/MESOS-3570 > > > Repository: mesos > > > Description > ------- > > Previously, the scheduler library used to chain calls on previous call > responses. This was inherently slow. This change adds support for pipelining > all calls to the master on a single connection via the `http::Connection` > abstraction in libprocess. > > This change also adds support for handling various error scenarios when we > notice a disconnection instead of just relying on the master detector for > invoking the `disconnected` callback. > > > Diffs > ----- > > src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 > > Diff: https://reviews.apache.org/r/43662/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
