----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43806/#review121079 -----------------------------------------------------------
I took a stab at rewording your comment. I particularly didn't like starting with an ambiguous "It". src/master/allocator/mesos/hierarchical.cpp (line 1069) <https://reviews.apache.org/r/43806/#comment182673> "The allocator only needs to rebalance if there is a framework registered with this role. The roleSorter contains only roles for registered frameworks, but quotaRoleSorter contains any role with quota set, regardless of whether any frameworks are registered with that role." This might belong above both the quota and roleSorter checks. - Adam B On Feb. 20, 2016, 6:26 p.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43806/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2016, 6:26 p.m.) > > > Review request for mesos, Adam B and Alexander Rukletsov. > > > Bugs: MESOS-3943 > https://issues.apache.org/jira/browse/MESOS-3943 > > > Repository: mesos > > > Description > ------- > > Add comments for rebalance. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d > > Diff: https://reviews.apache.org/r/43806/diff/ > > > Testing > ------- > > > Thanks, > > Yongqiao Wang > >
