> On Feb. 28, 2016, 9:16 p.m., Guangya Liu wrote: > > src/linux/fs.cpp, line 60 > > <https://reviews.apache.org/r/43718/diff/7/?file=1273083#file1273083line60> > > > > I think that should `continue` here, if one line failed, other lines > > should still be tried to see if the fs is supportted. > > > > But it would be good to log some WARNINIG message here before continue. > > > > @Jie Yu, @Shuai Lin, what do you say?
According to the comments, only one or two columns is accepted. If the data format did not math our expectation, we should return error. > // Each line of /proc/filesystems is "nodev" + "\t" + "fsname", and the > // field "nodev" is optional. For the details, check the kernel src code: - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review121141 ----------------------------------------------------------- On Feb. 28, 2016, 9:08 p.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43718/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2016, 9:08 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4707 > https://issues.apache.org/jira/browse/MESOS-4707 > > > Repository: mesos > > > Description > ------- > > Added fs::supported() function. > > > Diffs > ----- > > src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 > src/linux/fs.cpp 6bf87a19a795cf0a1970f160829b477a35cb789a > src/tests/containerizer/fs_tests.cpp > 29e43877612fa151e6f6d79268a7411272a7bfeb > > Diff: https://reviews.apache.org/r/43718/diff/ > > > Testing > ------- > > make check on ubuntu 14.04 64bit vm > > > Thanks, > > Shuai Lin > >
