-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44063/#review121143
-----------------------------------------------------------


Ship it!




Ship It!

- Klaus Ma


On Feb. 28, 2016, 6:27 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44063/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2016, 6:27 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4784
>     https://issues.apache.org/jira/browse/MESOS-4784
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To observe a changed metric in \`slave/container_launch_errors\` the
> triggering action should have taken place. Currently, the test usually
> passes, since hitting the metrics endpoint via \`Metrics()\` could block
> for longer times due to the endpoint's implicit rate limiting. Once we
> disable that blocking with MESOS-4783 this implicit assumption becomes
> invalid and the test would be much more likely to fail.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 
> 
> Diff: https://reviews.apache.org/r/44063/diff/
> 
> 
> Testing
> -------
> 
> make check with unoptimized build OS X both with rate-limiting enabled and 
> disabled
> 
> With MESOS-4783 applied the test fails before this patch and passes after 
> applying it.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to