> On Feb. 29, 2016, 12:39 a.m., James Peach wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 310 > > <https://reviews.apache.org/r/44151/diff/1/?file=1273688#file1273688line310> > > > > Darwin does have a ``gid_t`` type, why is this ifdef needed?
::getgrouplist on Darwin expect `int*` for gids. My clang complains about it if I use `gid_t gids[NGROUPS_MAX]`. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44151/#review121172 ----------------------------------------------------------- On Feb. 29, 2016, 12:08 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44151/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 12:08 a.m.) > > > Review request for mesos, Ian Downes and Timothy Chen. > > > Bugs: MESOS-4757 > https://issues.apache.org/jira/browse/MESOS-4757 > > > Repository: mesos > > > Description > ------- > > Added stout functions to get and set supplementary groud ids. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 84a2a021859d4e5c8547ad2a509eebda428a8255 > > Diff: https://reviews.apache.org/r/44151/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
