----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44153/#review121176 -----------------------------------------------------------
Patch looks great! Reviews applied: [44149, 44150, 44151, 44152, 44153] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Feb. 29, 2016, 12:09 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44153/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 12:09 a.m.) > > > Review request for mesos, Ian Downes and Timothy Chen. > > > Bugs: MESOS-4757 > https://issues.apache.org/jira/browse/MESOS-4757 > > > Repository: mesos > > > Description > ------- > > Currently, we call os::su(user) after pivot_root. This is problematic > because /etc/passwd and /etc/group might be missing in container's root > filesystem. We should instead, get the uid/gids before pivot_root, and > call setuid/setgroups after pivot_root. > > > Diffs > ----- > > src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e > src/slave/containerizer/mesos/launch.cpp > 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 > > Diff: https://reviews.apache.org/r/44153/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
