> On Feb. 28, 2016, 3:15 a.m., Guangya Liu wrote: > > docs/persistent-volume.md, lines 372-374 > > <https://reviews.apache.org/r/44047/diff/3/?file=1273027#file1273027line372> > > > > Only the `reserved_resources_full` was mentioned here, what about > > `used_resources_full` and `reserved_resources_full`? I think that those new > > metrics should also be mentioned here to clarify the meaning of them.
In my opinion, this is okay as-is: we don't document most of the keys in the JSON objects we return (which is unfortunate and something we should fix, but that's a separate project). > On Feb. 28, 2016, 3:15 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 1043 > > <https://reviews.apache.org/r/44047/diff/3/?file=1273029#file1273029line1043> > > > > s/offered resources/offered resources per agent I think this is implied by context (the comment occurs inside a for-each-slave loop). - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44047/#review121114 ----------------------------------------------------------- On Feb. 29, 2016, 7:13 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44047/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 7:13 a.m.) > > > Review request for mesos, Michael Park and Vinod Kone. > > > Bugs: MESOS-4667 > https://issues.apache.org/jira/browse/MESOS-4667 > > > Repository: mesos > > > Description > ------- > > This allows operators to list all the dynamic reservations and persistent > volumes in a cluster. This is important in itself; it also makes it easier to > use the `/unreserve` and `/destroy-volumes` endpoints. > > > Diffs > ----- > > docs/persistent-volume.md 47ada98413f1670e9fc4ebd9d1ead6af9b120184 > docs/reservation.md 450f4eec49d957b096df1380c3e79d5f743cc829 > src/master/http.cpp d6e1f22620dfc4271244a2983195cffc36da6e8e > src/tests/persistent_volume_endpoints_tests.cpp > 08b9102318b826bab9d2c1d389fb80b86949218c > > Diff: https://reviews.apache.org/r/44047/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
