-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43999/#review121264
-----------------------------------------------------------


Ship it!




This looks fine to me. I think it would help future generations to add a 
comment about where the relative paths actually point to and constructing this 
path is safe.

- James Peach


On Feb. 27, 2016, 1:55 a.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43999/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2016, 1:55 a.m.)
> 
> 
> Review request for mesos, James Peach and Kapil Arya.
> 
> 
> Bugs: MESOS-4774
>     https://issues.apache.org/jira/browse/MESOS-4774
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use relative path to create libraries symbolic link.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
> 
> Diff: https://reviews.apache.org/r/43999/diff/
> 
> 
> Testing
> -------
> 
> After make install, the library links will be relative path.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Reply via email to