> On Feb. 19, 2016, 9:31 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2373 > > <https://reviews.apache.org/r/41672/diff/12/?file=1203046#file1203046line2373> > > > > You can put framework id's into a `std::set` instead. Given there are > > two allocations, there is a guarantee, that there will be no attempts to > > put the same framework into the set twice. > > Yongqiao Wang wrote: > In the current implementation, we only need to check the allocation size > for each framework, it does not care the size of whole contianer (currentt is > hashmap), so I think use hashmap can meet the current requirement. > > Adam B wrote: > I think he's saying you can use a `std::set<FrameworkID> > allocatedFrameworks;` and inside your loop do: > `allocatedFrameworks.insert(allocation.get().frameworkId);` > and verify the allocations afterwards with: > `EXPECT_EQ(expectedFrameworksSet, allocatedFrameworks);`
Have changed `hashmap` to `std::set` - Yongqiao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review119839 ----------------------------------------------------------- On Jan. 20, 2016, 8:36 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41672/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 8:36 a.m.) > > > Review request for mesos, Adam B, Neil Conway, and Qian Zhang. > > > Bugs: MESOS-4200 > https://issues.apache.org/jira/browse/MESOS-4200 > > > Repository: mesos > > > Description > ------- > > Test case(s) for weights + allocation behaviour. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 953712149bd951789beb29c72779c4ac65aa48dc > > Diff: https://reviews.apache.org/r/41672/diff/ > > > Testing > ------- > > Make check done: > $ ./src/mesos-tests --gtest_filter=HierarchicalAllocatorTest.UpdateWeight > Source directory: /Users/yqwyq/Desktop/mesos > Build directory: /Users/yqwyq/Desktop/mesos/build > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from HierarchicalAllocatorTest > [ RUN ] HierarchicalAllocatorTest.UpdateWeight > [ OK ] HierarchicalAllocatorTest.UpdateWeight (87 ms) > [----------] 1 test from HierarchicalAllocatorTest (87 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (176 ms total) > [ PASSED ] 1 test. > > > Thanks, > > Yongqiao Wang > >
