----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43915/#review121447 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 313) <https://reviews.apache.org/r/43915/#comment183151> Please use explicit check here: ``` if (lower.get() == 0) ``` - Jie Yu On Feb. 29, 2016, 10:16 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43915/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 10:16 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4700 > https://issues.apache.org/jira/browse/MESOS-4700 > > > Repository: mesos > > > Description > ------- > > Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > f05cd55a9e080f44566ec7dcef22f11950496d6f > src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 > src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a > > Diff: https://reviews.apache.org/r/43915/diff/ > > > Testing > ------- > > make and make check > > > Thanks, > > Avinash sridharan > >
