----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40939/#review121519 -----------------------------------------------------------
Fix it, then Ship it! verified nothing changed in the posix implementation. 3rdparty/libprocess/3rdparty/stout/include/Makefile.am (line 117) <https://reviews.apache.org/r/40939/#comment183229> style 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/su.hpp (lines 28 - 29) <https://reviews.apache.org/r/40939/#comment183236> why the extra new line? 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/su.hpp (line 216) <https://reviews.apache.org/r/40939/#comment183237> no extra new-line 3rdparty/libprocess/3rdparty/stout/include/stout/os/su.hpp (lines 20 - 24) <https://reviews.apache.org/r/40939/#comment183231> Why does this file need to include these? 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/su.hpp (lines 46 - 56) <https://reviews.apache.org/r/40939/#comment183239> 2 new lines between functions in a namespace. - Joris Van Remoortere On March 1, 2016, 10:08 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40939/ > ----------------------------------------------------------- > > (Updated March 1, 2016, 10:08 p.m.) > > > Review request for mesos, Alex Naparu, Alex Clemmer, and M Lawindi. > > > Bugs: MESOS-4780 > https://issues.apache.org/jira/browse/MESOS-4780 > > > Repository: mesos > > > Description > ------- > > Stout: Marked `os::su` as deleted on Windows. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 03eff5a831283f6d298e9a1feecfdc7369cacfe7 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > f1d38029eef7e89dfdb8915158fba17865e6855b > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/su.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/su.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/su.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 84a2a021859d4e5c8547ad2a509eebda428a8255 > > Diff: https://reviews.apache.org/r/40939/diff/ > > > Testing > ------- > > OSX: make check > Windows: make.bat > > > Thanks, > > Daniel Pravat > >
