> On March 1, 2016, 11:47 p.m., Yi Sun wrote: > > 3rdparty/libprocess/src/windows/subprocess.cpp, line 152 > > <https://reviews.apache.org/r/44141/diff/1/?file=1272989#file1272989line152> > > > > The second param for strcpy_s is the number of chars to be copied. It > > doesn't seem right here.
It's the size of the dest buffer. I got it wrong. - Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44141/#review121541 ----------------------------------------------------------- On March 1, 2016, 8:58 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44141/ > ----------------------------------------------------------- > > (Updated March 1, 2016, 8:58 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > ------- > > Windows: Forked subprocess.cpp, added `Windows` implementation. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d > 3rdparty/libprocess/include/process/subprocess.hpp > e0c306aa5cf5f393abb73768bbd287c45730f076 > 3rdparty/libprocess/src/CMakeLists.txt > 12dfaf61b801372b6ec70c535080fde350866fb8 > 3rdparty/libprocess/src/subprocess.cpp > 44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c > 3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION > 3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44141/diff/ > > > Testing > ------- > > OSX: make check > Windows: build/run > > > Thanks, > > Daniel Pravat > >
