> On March 1, 2016, 10:32 p.m., Anand Mazumdar wrote: > > src/internal/devolve.cpp, line 123 > > <https://reviews.apache.org/r/44218/diff/1/?file=1275709#file1275709line123> > > > > Nit: s/but `Call::Subscribe` has// > > > > Since we are inside `devolve` for conversion to `Call::Subscribe`, the > > above words are redundant.
I ended up reverting the devolve change and updating the master code to ignore the force field for http scheduler. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44218/#review121516 ----------------------------------------------------------- On March 1, 2016, 7:47 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44218/ > ----------------------------------------------------------- > > (Updated March 1, 2016, 7:47 p.m.) > > > Review request for mesos, Anand Mazumdar and Greg Mann. > > > Bugs: MESOS-4712 > https://issues.apache.org/jira/browse/MESOS-4712 > > > Repository: mesos > > > Description > ------- > > See the https://issues.apache.org/jira/browse/MESOS-4712 for details. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 4aa32e6422a458221b7829ec6f5223e6a013feae > include/mesos/v1/scheduler/scheduler.proto > 5d0e6c7dfcdbe004a8629361328287a88d53a1b6 > src/examples/event_call_framework.cpp > d07d05d4b1eae5d2286d3fc1fdc32247bc19cada > src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d > src/tests/scheduler_http_api_tests.cpp > 428e12646d80b45daec30cfe607b97f36170fdf5 > src/tests/scheduler_tests.cpp 70c5b218aa231b21277580567d92f31c16a95efb > > Diff: https://reviews.apache.org/r/44218/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
