----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44236/#review121566 -----------------------------------------------------------
Patch looks great! Reviews applied: [44236] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 2, 2016, 12:01 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44236/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 12:01 a.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-4825 > https://issues.apache.org/jira/browse/MESOS-4825 > > > Repository: mesos > > > Description > ------- > > Update slave's version after re-registering. > > > Diffs > ----- > > src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d > src/master/master.cpp f242b70a0ebeff9cd3204343735b8615230a6108 > > Diff: https://reviews.apache.org/r/44236/diff/ > > > Testing > ------- > > Test it manually. > > Test Steps: > 1. Start 0.28.0 master > 2. Start 0.28.0 slave > 3. Stop 0.28.0 slave > 4. Start 0.27.0 slave with the same work directory > > Test Results: > > ``` > Klauss-MacBook-Pro:mesos klaus$ curl http://localhost:5050/slaves | python -m > json.tool > % Total % Received % Xferd Average Speed Time Time Time > Current > Dload Upload Total Spent Left Speed > 100 588 100 588 0 0 79277 0 --:--:-- --:--:-- --:--:-- 84000 > { > "slaves": [ > { > "active": true, > "attributes": {}, > "hostname": "192.168.1.101", > "id": "8635c7aa-6c20-44ec-ac3f-d69aec48f243-S0", > "offered_resources": { > "cpus": 0.0, > "disk": 0.0, > "mem": 0.0 > }, > "offered_resources_full": [], > "pid": "slave(1)@192.168.1.101:5051", > "registered_time": 1456874482.32198, > "reserved_resources": {}, > "reserved_resources_full": {}, > "resources": { > "cpus": 8.0, > "disk": 470832.0, > "mem": 15360.0, > "ports": "[31000-32000]" > }, > "unreserved_resources": { > "cpus": 8.0, > "disk": 470832.0, > "mem": 15360.0, > "ports": "[31000-32000]" > }, > "used_resources": { > "cpus": 0.0, > "disk": 0.0, > "mem": 0.0 > }, > "used_resources_full": [], > "version": "0.28.0" > } > ] > } > Klauss-MacBook-Pro:mesos klaus$ curl http://localhost:5050/slaves | python -m > json.tool > % Total % Received % Xferd Average Speed Time Time Time > Current > Dload Upload Total Spent Left Speed > 100 625 100 625 0 0 85592 0 --:--:-- --:--:-- --:--:-- 89285 > { > "slaves": [ > { > "active": true, > "attributes": {}, > "hostname": "192.168.1.101", > "id": "8635c7aa-6c20-44ec-ac3f-d69aec48f243-S0", > "offered_resources": { > "cpus": 0.0, > "disk": 0.0, > "mem": 0.0 > }, > "offered_resources_full": [], > "pid": "slave(1)@192.168.1.101:5051", > "registered_time": 1456874482.32198, > "reregistered_time": 1456874497.25686, > "reserved_resources": {}, > "reserved_resources_full": {}, > "resources": { > "cpus": 8.0, > "disk": 470832.0, > "mem": 15360.0, > "ports": "[31000-32000]" > }, > "unreserved_resources": { > "cpus": 8.0, > "disk": 470832.0, > "mem": 15360.0, > "ports": "[31000-32000]" > }, > "used_resources": { > "cpus": 0.0, > "disk": 0.0, > "mem": 0.0 > }, > "used_resources_full": [], > "version": "0.27.0" > } > ] > } > ``` > > > Thanks, > > Klaus Ma > >