> On March 1, 2016, 11:21 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/Makefile.am, line 48 > > <https://reviews.apache.org/r/43908/diff/1/?file=1271187#file1271187line48> > > > > style
I'd just like to clarify that I made this line up in `git diff` because it was off... I guess git is subtly different in how it presents diffs. > On March 1, 2016, 11:21 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, lines 214-297 > > <https://reviews.apache.org/r/43908/diff/1/?file=1271191#file1271191line214> > > > > I don't understand why these got removed. > > They are not covered by the tests your introduced. These tests are completely redundant. They exist in both `filesystem_tests.cpp` and `os_tests.cpp`. So I've removed them from `os.hpp`. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/#review121532 ----------------------------------------------------------- On Feb. 25, 2016, 7:40 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43908/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 7:40 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > ------- > > Stout:[2/2] Added significant test coverage of `os::rmdir`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 756aa29ed134bf10a645af7f6562f86dc8e488f5 > 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt > 3c65d0422dc6e198180d53d1c9e6cb2839137434 > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp > d0592ef8a774d380e9df66b7e623eb72b29a28b3 > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > a2bc5c40167896a3df2cfb5b1f3cf58c20ea1422 > > Diff: https://reviews.apache.org/r/43908/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
