----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44275/ -----------------------------------------------------------
Review request for mesos and Vinod Kone. Bugs: MESOS-4029 https://issues.apache.org/jira/browse/MESOS-4029 Repository: mesos Description ------- This change fixes the tests using the scheduler library by explicitly invoking `stop()` from the testing interface. This ensures that no further callbacks are delivered to the scheduler. For one-off async callbacks that are already on the libprocess queue we need to do a `Clock::settle` to ensure they are executed before the mock object goes out of scope. Diffs ----- src/tests/mesos.hpp 0c55d5901753dc3f6e71486f727a2af7bd920429 Diff: https://reviews.apache.org/r/44275/diff/ Testing ------- make check + Induced a sleep in the async callbacks. Previously, the test used to crash but with the fix it no longer crashes. Thanks, Anand Mazumdar