-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44325/#review121921
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/metrics/metrics.cpp (line 192)
<https://reviews.apache.org/r/44325/#comment183776>

    We often include a period and newline in the http response message, 
otherwise it tends to print strangely with tools like curl. Check out files.cpp 
for examples, but I realize that this has become really inconsistent. For now, 
I'll commit just the Failure changes.


- Ben Mahler


On March 3, 2016, 9:20 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44325/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 9:20 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> 8812fe213e1005d7b8a7463d1ae2f30f6a80e93d 
> 
> Diff: https://reviews.apache.org/r/44325/diff/
> 
> 
> Testing
> -------
> 
> `make check` on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to