-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44362/#review121957
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/memory_pressure_tests.cpp (line 157)
<https://reviews.apache.org/r/44362/#comment183819>

    // Pause the clock to ensure that the reaper doesn't reap the exited
    // command executor and inform the containerizer/slave.



src/tests/containerizer/memory_pressure_tests.cpp (line 242)
<https://reviews.apache.org/r/44362/#comment183820>

    split this expecation and move the killed to just before killing the task.



src/tests/containerizer/memory_pressure_tests.cpp (line 254)
<https://reviews.apache.org/r/44362/#comment183821>

    s/checkpointed/_statusUpdateAcknowledgement/


- Vinod Kone


On March 3, 2016, 11:29 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44362/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 11:29 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-4047
>     https://issues.apache.org/jira/browse/MESOS-4047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prevents the container to be reaped by pausing the clock before
> killing the task, so that measurements from the containerizer can be
> taken even if the executor has already exited.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/memory_pressure_tests.cpp 
> 79f134996c4b80bf49cbb8bee28eab5e6b4f5822 
> 
> Diff: https://reviews.apache.org/r/44362/diff/
> 
> 
> Testing
> -------
> 
> ```bash
> MESOS_VERBOSE=1 sudo ./.libs/mesos-tests 
> --gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_*" \
>     --gtest_repeat=1000 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to