> On Feb. 22, 2016, 4:41 a.m., Klaus Ma wrote:
> > src/slave/flags.cpp, line 437
> > <https://reviews.apache.org/r/39939/diff/1/?file=1115726#file1115726line437>
> >
> >     I think we need to handle feature interaction with 
> > `docker_mesos_image`. Currently, we mount unix socket into container; but 
> > it'll failed when using TCP socket.
> 
> haosdent huang wrote:
>     Hi, @klaus1982 Sorry to forgot update this. Do you mean we need add a 
> check here?
> 
> haosdent huang wrote:
>     My concern here is if we use host network when we launch slave in docker, 
> use tcp protocol should still works.
> 
> Klaus Ma wrote:
>     When `docker_mesos_image` is enabled, `docker_socket` are mounted into 
> docker by volume which is not worked for TCP ( 
> https://github.com/apache/mesos/blob/master/src/slave/containerizer/docker.cpp#L293
>  ).
>     
>     IMO, two options:
>     
>     1. Highlight in document that TCP docker_socket can not work with 
> `docker_mesos_image`
>     2. Add logic for `docker_mesos_image`, just pass docker_socket into slave 
> in docker instead of mounting it; we also need to update document that it's 
> user's responsibility to make sure network is accessable.

Thank you very much. I add a check here.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review120096
-----------------------------------------------------------


On March 4, 2016, 2:23 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 2:23 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
>     https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to