> On March 4, 2016, 1:15 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 24 > > <https://reviews.apache.org/r/44269/diff/3/?file=1279088#file1279088line24> > > > > We try to avoid using this now. Let's use 'using process::XXX' > > explicitly here. In your case: > > > > ``` > > using process::Future; > > using process::Owned; > > using process::PID; > > ```
Agree! - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/#review121884 ----------------------------------------------------------- On March 3, 2016, 9:57 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44269/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 9:57 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Added the framework of 'network/cni' isolator. > > > Diffs > ----- > > src/CMakeLists.txt 0eabfad66f43adff12d08dbf34ca3db1b801c49e > src/Makefile.am b30cc25f61856d6417437547baaa0bb338a30d63 > src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44269/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >