> On March 3, 2016, 9:12 p.m., Till Toenshoff wrote:
> > support/mesos-style.py, line 90
> > <https://reviews.apache.org/r/44343/diff/1/?file=1279526#file1279526line90>
> >
> >     Are the two leading spaces intentional?

Yes, this is intentional to be consistent with `cpplint`'s output format, see 
https://github.com/apache/mesos/blob/master/support/cpplint.py#L1012 (we use 
the default output format which is `emacs`).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44343/#review121927
-----------------------------------------------------------


On March 3, 2016, 6:06 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44343/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 6:06 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used single space in license check error message.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py 815d88c1935ae8248cd76a73d3dd613312b1d730 
> 
> Diff: https://reviews.apache.org/r/44343/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to