----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44336/#review122110 -----------------------------------------------------------
Patch looks great! Reviews applied: [43105, 44331, 44332, 44333, 43138, 44334, 44335, 44336] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 4, 2016, 2:52 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44336/ > ----------------------------------------------------------- > > (Updated March 4, 2016, 2:52 p.m.) > > > Review request for mesos, Bernd Mathiske and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > We should not enumerate variables if the corresponding instance is the > only one of such type in the test. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 3e4ad31925e1b815a74d67fa3962d23fa5bc89d1 > > Diff: https://reviews.apache.org/r/44336/diff/ > > > Testing > ------- > > On Mac OS 10.10.4: > > `make check` > > `GTEST_FILTER="HierarchicalAllocatorTest.*" ./bin/mesos-tests.sh > --gtest_repeat=100 --gtest_break_on_failure --gtest_shuffle` > > > Thanks, > > Alexander Rukletsov > >
