-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41049/#review122158
-----------------------------------------------------------



Bad patch!

Reviews applied: [41049]

Failed command: ./support/apply-review.sh -n -r 41049

Error:
2016-03-04 23:51:33 URL:https://reviews.apache.org/r/41049/diff/raw/ 
[36629/36629] -> "41049.patch" [1]
error: patch failed: src/python/native/ext_modules.py.in:1
error: src/python/native/ext_modules.py.in: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/11831/console

- Mesos ReviewBot


On March 4, 2016, 7:51 p.m., Steve Niemitz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41049/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 7:51 p.m.)
> 
> 
> Review request for mesos, Till Toenshoff and Vinod Kone.
> 
> 
> Bugs: MESOS-4090
>     https://issues.apache.org/jira/browse/MESOS-4090
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> New python lib with only the executor driver.
> 
> This patch produces a new python egg, mesos.executor, which contains only the 
> code needed to create a MesosExecutorDriver.  By doing so, the linker can 
> remove unused code in libmesos_no_3rdparty.a, and therefor not include any 
> external dependencies in the resulting _mesos.so.
> 
> 
> Diffs
> -----
> 
>   configure.ac b30a8d30076f3068fd7d5fc8ccea1982639e998a 
>   src/Makefile.am 0409491b92c9720d60ad76fdbc2edff554fb4965 
>   src/python/executor/setup.py.in PRE-CREATION 
>   src/python/executor/src/mesos/__init__.py PRE-CREATION 
>   src/python/executor/src/mesos/executor/__init__.py PRE-CREATION 
>   src/python/executor/src/mesos/executor/module.cpp PRE-CREATION 
>   src/python/native/ext_modules.py.in 
> 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
>   src/python/native/setup.py.in 49ed61293281f65d6597470ce3697326ac769032 
>   src/python/native/src/mesos/native/__init__.py 
> 226f94357cd81b700706edd68c94de461647fa1b 
>   src/python/native/src/mesos/native/mesos_executor_driver_impl.hpp  
>   src/python/native/src/mesos/native/mesos_executor_driver_impl.cpp 
> 7838a07ac12034a5eed2f459bd11e5e0a07e94de 
>   src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
> f8be49bf5feb6675c3c8e6a1df75a5e079d09fcc 
>   src/python/native/src/mesos/native/module.hpp 
> 2cf7b57077d10c071bd4b8f36e2cb43041fc168d 
>   src/python/native/src/mesos/native/module.cpp 
> 6e672a219999edf0e9df1d95688620ea9cc6a1b2 
>   src/python/native/src/mesos/native/proxy_executor.hpp  
>   src/python/native/src/mesos/native/proxy_executor.cpp 
> 706f417b547bb9878346902b2a2f98b1afade5ad 
>   src/python/native/src/mesos/native/proxy_scheduler.hpp  
>   src/python/native/src/mesos/native/proxy_scheduler.cpp 
> 8afb3380d99b4dc9c4f7b3d926f4a5b1d6e94c20 
>   src/python/native_common/ext_modules.py.in PRE-CREATION 
>   src/python/scheduler/setup.py.in PRE-CREATION 
>   src/python/scheduler/src/mesos/__init__.py PRE-CREATION 
>   src/python/scheduler/src/mesos/scheduler/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41049/diff/
> 
> 
> Testing
> -------
> 
> On CentOS 7, GCC 4.8.5:
> - make distcheck
> - Tested with aurora executor
> - Made sure mesos.scheduler still worked
> - Made sure mesos.native still worked
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Reply via email to