> On March 4, 2016, 12:27 p.m., Klaus Ma wrote:
> > src/slave/containerizer/containerizer.cpp, line 105
> > <https://reviews.apache.org/r/44366/diff/1/?file=1280284#file1280284line105>
> >
> >     `` for --nvidia_gpus; not only this line, please also update them in 
> > the following comments.

Sorry, I don't think I understand.  What are you proposing here?


> On March 4, 2016, 12:27 p.m., Klaus Ma wrote:
> > src/slave/containerizer/containerizer.cpp, line 115
> > <https://reviews.apache.org/r/44366/diff/1/?file=1280284#file1280284line115>
> >
> >     I'd like to say "`--navidia_gpus` must be set when specifying `gpu` 
> > resources."

Are you just suggesting to make the Error string shorter?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44366/#review122059
-----------------------------------------------------------


On March 4, 2016, 1:11 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44366/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 1:11 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Rob Todd.
> 
> 
> Bugs: MESOS-4865
>     https://issues.apache.org/jira/browse/MESOS-4865
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently we can either infer the number of GPUs to offer as resources
> from the --nvidia_gpus flag, or pass the amount explicity as a "gpus"
> resource. In the future, we will generalize this via autodiscovery of
> gpus and support for gpus types other than Nvidia.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 388c4f383b77be490cb2debb64a734c6d6e4a176 
>   include/mesos/v1/resources.hpp 64ad8bf08230aeaa173325364c91b765f091210e 
>   src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54 
>   src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
>   src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
>   src/slave/containerizer/containerizer.cpp 
> f6fc7863d0c215611f170dc0c89aa229407b5137 
>   src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d 
> 
> Diff: https://reviews.apache.org/r/44366/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Reply via email to