----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44286/#review122274 -----------------------------------------------------------
Fix it, then Ship it! Looks good. Just wondering if we should also validate the response's content-type=json. Perhaps in a separate patch, so this one can land asap? What do you think? src/tests/fault_tolerance_tests.cpp (lines 230 - 233) <https://reviews.apache.org/r/44286/#comment184194> Should we also `AWAIT_EXPECT_RESPONSE_HEADER_EQ(APPLICATION_JSON, "Content-Type", masterState);`? Or is the `ASSERT_SOME(parse)` good enough to indicate that we received json? - Adam B On March 2, 2016, 12:53 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44286/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 12:53 p.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Repository: mesos > > > Description > ------- > > Unified/Added Future checks for http methods in tests. > > > Diffs > ----- > > src/tests/fault_tolerance_tests.cpp > 982468f851cd9d95eb6cde7c57f2d737d46a827c > src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a > src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf > > Diff: https://reviews.apache.org/r/44286/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Joerg Schad > >