> On Feb. 24, 2016, 7:57 a.m., Adam B wrote: > > docs/app-framework-development-guide.md, line 144 > > <https://reviews.apache.org/r/43819/diff/1/?file=1263766#file1263766line144> > > > > Get rid of the `virtual` and `= 0` since that's not a part of the API > > that their scheduler will call. They're not implementing a new > > SchedulerDriver, they're just instantiating one and calling its methods.
I actually just wanted it to be consistent with the below part. Will remove `= 0` from both parts - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/#review120465 ----------------------------------------------------------- On Feb. 22, 2016, 3 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43819/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 3 a.m.) > > > Review request for mesos, Adam B and Neil Conway. > > > Repository: mesos > > > Description > ------- > > Added Scheduler-Driver API to app-framework-development-guide.md. > > > Diffs > ----- > > docs/app-framework-development-guide.md > e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d > > Diff: https://reviews.apache.org/r/43819/diff/ > > > Testing > ------- > > Viewed via gist (https://gist.github.com/joerg84/b4bf279a55e1b62051e6) and > via docker website container. > > > Thanks, > > Joerg Schad > >
