----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44365/#review122628 -----------------------------------------------------------
src/slave/flags.hpp (line 92) <https://reviews.apache.org/r/44365/#comment184736> Can you put this in an ifdef? src/slave/flags.cpp (lines 597 - 607) <https://reviews.apache.org/r/44365/#comment184735> -s/nvidia_gpus/nvidia_gpu_devices/ -capitalize NVML -s/as a resource/as resources/ -maybe put the nvidia-smi comment in a parenthetical? -The third sentence seems to be already expressed in the first? Perhaps clarify that the isolator will be used only if the `--isolation` flag contains the right value. -We can probably omit or re-pharse the last sentence since this flag is omitted from the program if the configure flag is not present. src/slave/flags.cpp (lines 606 - 607) <https://reviews.apache.org/r/44365/#comment184746> I was going to suggest we add a validator here, but even better would be to add a parse specialization to src/common/parse.hpp and just avoid the need for the extra validation altogether. - Ben Mahler On March 8, 2016, 10:47 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44365/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 10:47 p.m.) > > > Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. > > > Bugs: MESOS-4864 > https://issues.apache.org/jira/browse/MESOS-4864 > > > Repository: mesos > > > Description > ------- > > Added flag to specify available Nvidia GPUs on an agent's command line. > > > Diffs > ----- > > docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c > src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 > src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 > > Diff: https://reviews.apache.org/r/44365/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
