----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44470/#review122833 -----------------------------------------------------------
src/tests/containerizer/runtime_isolator_tests.cpp (lines 173 - 174) <https://reviews.apache.org/r/44470/#comment184926> Can we use environment->mkdtemp(). Ditto on previous reviews. src/tests/containerizer/runtime_isolator_tests.cpp (line 178) <https://reviews.apache.org/r/44470/#comment184927> Ditto. src/tests/containerizer/runtime_isolator_tests.cpp (lines 192 - 194) <https://reviews.apache.org/r/44470/#comment184935> Do you need to do that for all tests to be consistnet? src/tests/containerizer/runtime_isolator_tests.cpp (line 195) <https://reviews.apache.org/r/44470/#comment184929> Ditto. Using slave's work_directory. src/tests/containerizer/runtime_isolator_tests.cpp (line 261) <https://reviews.apache.org/r/44470/#comment184930> RUNTIME? Also, this needs internet access. So CURL_INTERNET - Jie Yu On March 7, 2016, 9:47 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44470/ > ----------------------------------------------------------- > > (Updated March 7, 2016, 9:47 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4889 > https://issues.apache.org/jira/browse/MESOS-4889 > > > Repository: mesos > > > Description > ------- > > Implemented runtime isoaltor default entrypoint test. > > > Diffs > ----- > > src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44470/diff/ > > > Testing > ------- > > make check > > sudo ./bin/mesos-tests.sh > > > Thanks, > > Gilbert Song > >