> On March 10, 2016, 7:47 a.m., Yongqiao Wang wrote:
> > docs/weights.md, lines 40-46
> > <https://reviews.apache.org/r/44584/diff/1/?file=1293359#file1293359line40>
> >
> >     Why adjust this order? `role` is an optional item in `/weights` `PUT` 
> > request, and `/weights` is focus on changing the weight, so I put `weight` 
> > item firstly.

I think putting "role" first is more readable, and is consistent with the 
`--weights` syntax. If you want to emphasize that "role" is optional, I suggest 
documenting that explicitly.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44584/#review122893
-----------------------------------------------------------


On March 10, 2016, 7:28 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44584/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 7:28 a.m.)
> 
> 
> Review request for mesos, Adam B and Yongqiao Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved docs for dynamic weights.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md f6e84023b90e560594429826ed7163310d62b265 
>   docs/roles.md 65d6ddf46ac394389c70a3faf5cc85c5cf892478 
>   docs/weights.md dec2ddd6516d2d3a9926f6410f8309eb2de40c3c 
>   src/master/flags.cpp c1dd127109f1ba96a8f9b95f3eb99dfeb43f7d28 
> 
> Diff: https://reviews.apache.org/r/44584/diff/
> 
> 
> Testing
> -------
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to