----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44675/#review122996 -----------------------------------------------------------
3rdparty/libprocess/src/metrics/metrics.cpp (line 234) <https://reviews.apache.org/r/44675/#comment185115> (1) Why not just `snapshot`? (2) We don't use default capture by reference. Could you explicitly list the variables that need to be captured here? - Michael Park On March 10, 2016, 8:19 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44675/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 8:19 p.m.) > > > Review request for mesos, Michael Park, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-4740 > https://issues.apache.org/jira/browse/MESOS-4740 > > > Repository: mesos > > > Description > ------- > > Updated `/metrics/snapshot` endpoint to use `jsonify`. > > > Diffs > ----- > > 3rdparty/libprocess/src/metrics/metrics.cpp > f1e6774ebf8670b006ba6ea181439d0ef1529b40 > > Diff: https://reviews.apache.org/r/44675/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Cong Wang > >
