> On March 10, 2016, 4:02 a.m., Alexander Rojas wrote:
> > I just did a grep and I found this:
> > 
> > ```sh
> > $ ag --cpp --ignore="build/.*" '\"mesos\"' .
> > # ...
> > src/authentication/http/basic_authenticator_factory.cpp
> > 66:  Authenticator* authenticator = new BasicAuthenticator("mesos", 
> > credentials);
> > 
> > src/master/constants.hpp
> > 136:// Name of the default, "mesos" HTTP authentication realm.
> > # ...
> > ```
> > 
> > at least those two need to be changed.
> 
> Adam B wrote:
>     Hmm, if the first one is used by both master and agent, then we might 
> need to pass the realm as a parameter to the factory's create method.
>     Good call with the grep, Alexander.

Thanks for catching this, Alex! I posted a patch which alters the default 
authenticator to accept a realm when it's created: 
https://reviews.apache.org/r/44678/


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review122874
-----------------------------------------------------------


On March 10, 2016, 9:40 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44523/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 9:40 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4849
>     https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed the master's default HTTP authentication realm.
> 
> 
> Diffs
> -----
> 
>   src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
>   src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 
> 
> Diff: https://reviews.apache.org/r/44523/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to