----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44689/#review123075 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On March 11, 2016, 1:38 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44689/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 1:38 a.m.) > > > Review request for mesos, Ben Mahler and Neil Conway. > > > Bugs: MESOS-4914 > https://issues.apache.org/jira/browse/MESOS-4914 > > > Repository: mesos > > > Description > ------- > > Previously it was just a string type and we checked for 'existence' of > a delegate by comparing (delegate != ""). Using an Option is the > preferred method for things like this. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp > 45ccf9d0461ed2f6dbb0f5084839582d6be3dd1c > 3rdparty/libprocess/src/process.cpp > 01bc19bc6f4d78923bb3796b7dd0a9ab2b3108d1 > > Diff: https://reviews.apache.org/r/44689/diff/ > > > Testing > ------- > > I recompiled mesos and ran 'make check'. > > > Thanks, > > Kevin Klues > >
