----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/#review123102 -----------------------------------------------------------
src/authentication/http/basic_authenticator_factory.cpp (lines 58 - 60) <https://reviews.apache.org/r/44678/#comment185249> This is exactly the reason why I didn't do it this way, since now we cannot have a user name _authentication_realm_ so we effectively introduced a keyword. Come to thing about it, I really went the lazy way and a better solution would be to accept an entry called _credentials_ which is a list of key value pairs, i.e. ```js { // … other module entries. "parameters" : [ { "key" : "authentication_realm", "value" : "tatooine" }, { "key" : "credentials", "value" : "user1 passwd1\nuser2 passwd2" } ] } ``` src/tests/http_authentication_tests.cpp (line 145) <https://reviews.apache.org/r/44678/#comment185248> I love this realm. - Alexander Rojas On March 10, 2016, 11:58 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44678/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 11:58 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till > Toenshoff. > > > Bugs: MESOS-4850 > https://issues.apache.org/jira/browse/MESOS-4850 > > > Repository: mesos > > > Description > ------- > > Modified basic HTTP authenticator creator to accept realm. > > To accommodate different authentication realms for the master and agent, the > default basic HTTP authenticator needs to accept its authentication realm as > a parameter. This patch adds this parameter and modifies the HTTP > authentication tests to validate it appropriately. > > > Diffs > ----- > > include/mesos/authentication/http/basic_authenticator_factory.hpp > c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 > src/authentication/http/basic_authenticator_factory.cpp > 62f851685db3b42c52bbcb7cff3e4f4703004ed7 > src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc > src/tests/http_authentication_tests.cpp > cf2bb762272fa38e04e5c26aef2858300bbd0459 > > Diff: https://reviews.apache.org/r/44678/diff/ > > > Testing > ------- > > `make check` was used to test on both OSX and CentOS 7. > > > Thanks, > > Greg Mann > >
