> On March 10, 2016, 10:03 p.m., Joris Van Remoortere wrote: > > src/module/manager.cpp, lines 50-53 > > <https://reviews.apache.org/r/44694/diff/1/?file=1295217#file1295217line50> > > > > Why the re-ordering here?
The idea is to keep all <modulename, <attributes>> mappings close together. > On March 10, 2016, 10:03 p.m., Joris Van Remoortere wrote: > > src/module/manager.cpp, line 201 > > <https://reviews.apache.org/r/44694/diff/1/?file=1295217#file1295217line201> > > > > Is this an internal invariant? Yes, the hashmap provides it. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44694/#review123077 ----------------------------------------------------------- On March 11, 2016, 2:50 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44694/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 2:50 a.m.) > > > Review request for mesos, Joris Van Remoortere, Michael Park, and Till > Toenshoff. > > > Bugs: MESOS-4903 > https://issues.apache.org/jira/browse/MESOS-4903 > > > Repository: mesos > > > Description > ------- > > As long as the module manifest(s) being loaded don't conflict with the > already loaded manifests, the module manager will allow multiple calls > to `load()`. > > > Diffs > ----- > > src/module/manager.hpp 89dd06097a355c6455e8f8af7d3d98847a304c90 > src/module/manager.cpp 6ae99504005581b22a44768949b1d305cec517d9 > src/tests/module_tests.cpp 497ed87bddce23bb457373da40dc87111c04136d > > Diff: https://reviews.apache.org/r/44694/diff/ > > > Testing > ------- > > Added new tests and ran make check. > > > Thanks, > > Kapil Arya > >
